Fix #25848: Crash when dragging item from "More" palette to parent palette#26266
Merged
mathesoncalum merged 1 commit intomusescore:masterfrom Jan 30, 2025
Merged
Conversation
mathesoncalum
force-pushed
the
25848-more_palette_crash
branch
from
00cd67d to
705123c
Compare
cbjeukendrup
approved these changes
Jan 29, 2025
mathesoncalum
force-pushed
the
25848-more_palette_crash
branch
3 times, most recently
from
c0fc921 to
77d08a4
Compare
mathesoncalum
force-pushed
the
25848-more_palette_crash
branch
from
77d08a4 to
0b33059
Compare
Contributor
|
Tested on MacOS 15, Windows 11, Ubuntu 22.04.3. Approved |
cbjeukendrup
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #25848
It took me a while to figure out some consistent repro steps for this one but I got there in the end. For the crash to occur, the “more” popup needs to disappear mid-drag. This can happen when the number of rows changes in the parent palette, and the “more” button is shuffled out of view.
This crash was introduced with 01735eb where we placed the
MoreElementsPopupinside aLoader. The problem seems to be that the drag continues to reference theMoreElementsPopupafter theLoaderdestroys it inonClosed. My proposed solution is to defer the deactivation of theLoaderuntil after the drag has finished (if necessary).(Note this PR initially attempted some refactoring to
PaletteTree.qmlbut in the end this was causing more harm than good)